Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch file for validate-release job #10

Merged
merged 1 commit into from
Sep 15, 2023
Merged

add patch file for validate-release job #10

merged 1 commit into from
Sep 15, 2023

Conversation

JasonPowr
Copy link

Small patch file to fix the current job failing, ref: sigstore#3169

@lance
Copy link
Member

lance commented Sep 13, 2023

/approve
/ok-to-test

@lance
Copy link
Member

lance commented Sep 13, 2023

@JasonPowr I think this should also be backported to midstream...

/cherry-pick midstream-v2.1.1

@openshift-cherrypick-robot
Copy link

@lance: once the present PR merges, I will cherry-pick it on top of midstream-v2.1.1 in a new PR and assign it to you.

In response to this:

@JasonPowr I think this should also be backported to midstream...

/cherry-pick midstream-v2.1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lance
lance approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit 99ac5fd into securesign:main Sep 15, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 15, 2023
Merged
@openshift-cherrypick-robot
Copy link

@lance: new pull request created: #11

In response to this:

@JasonPowr I think this should also be backported to midstream...

/cherry-pick midstream-v2.1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@tommyd450 tommyd450 Awaiting requested review from tommyd450

Assignees

@lance lance

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonPowr @lance @openshift-cherrypick-robot